Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Fix a typo in test_field.py that caused the failure of CI #1523

Merged
merged 1 commit into from
Jul 18, 2020
Merged

[test] Fix a typo in test_field.py that caused the failure of CI #1523

merged 1 commit into from
Jul 18, 2020

Conversation

Rullec
Copy link
Contributor

@Rullec Rullec commented Jul 17, 2020

Maybe here is a typo in test_field.py ;-)

@Rullec Rullec changed the title [test] Fix a typo in test_field.py that caused failure of CI [test] Fix a typo in test_field.py that caused the failure of CI Jul 17, 2020
archibate
archibate approved these changes Jul 17, 2020
View reviewed changes
Copy link
Collaborator

@archibate archibate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Jul 17, 2020 •
edited
Loading

Codecov Report

Merging #1523 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1523      +/-   ##
==========================================
- Coverage   66.18%   66.17%   -0.01%     
==========================================
  Files          38       38              
  Lines        5353     5405      +52     
  Branches      969      976       +7     
==========================================
+ Hits         3543     3577      +34     
- Misses       1643     1660      +17     
- Partials      167      168       +1
Impacted Files Coverage Δ
python/taichi/lang/impl.py 90.31% <100.00%> (+0.09%) ⬆️
python/taichi/lang/matrix.py 90.74% <100.00%> (+0.17%) ⬆️
python/taichi/lang/ast_checker.py 70.58% <0.00%> (-2.14%) ⬇️
python/taichi/misc/gui.py 23.70% <0.00%> (-2.12%) ⬇️
python/taichi/lang/__init__.py 79.84% <0.00%> (+0.15%) ⬆️
python/taichi/lang/meta.py 64.17% <0.00%> (+2.27%) ⬆️
python/taichi/lang/kernel_arguments.py 100.00% <0.00%> (+6.45%) ⬆️
python/taichi/lang/snode.py 93.33% <0.00%> (+7.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f7637...bb518e7. Read the comment docs.

@archibate archibate merged commit e518981 into taichi-dev:master Jul 18, 2020
@yuanming-hu yuanming-hu mentioned this pull request Jul 18, 2020
Merged
@Rullec Rullec deleted the fix_CI_fail branch July 26, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archibate archibate archibate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rullec @archibate